andras/vault-link
1
0
Fork 0
Code Issues Pull requests 18 Projects Releases 55 Packages Wiki Activity Actions 1

Refactor and small fixes #179

Merged
schmelczer merged 17 commits from asch/refactor into main 2025-12-07 16:42:23 +00:00
Conversation 1 Commits 17 Files changed 168 +19490 -16445
schmelczer commented 2025-12-07 16:06:37 +00:00 (Migrated from github.com)
Copy link
No description provided.
copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed 2025-12-07 16:40:45 +00:00
copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment
Copy link

Pull request overview

This PR refactors event listener management throughout the codebase by introducing a reusable EventListeners class, removes the clap-verbosity-flag dependency in favor of a custom LogLevel enum, and includes various code quality improvements such as fixing indentation, adding test cleanup, and improving file watching in the CLI.

Key Changes:

  • Introduced EventListeners utility class to standardize event listener management across the codebase
  • Replaced clap-verbosity-flag with custom LogLevel enum for better control over logging configuration
  • Updated file watcher implementation to use the watcher package for more reliable file system monitoring

Reviewed changes

Copilot reviewed 51 out of 168 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
sync-server/src/utils/log_level.rs New LogLevel enum with conversion to tracing levels
sync-server/src/config/logging_config.rs Added log_level field to configuration with default value
sync-server/src/main.rs Updated to use LogLevel from config instead of CLI args
sync-server/src/cli/args.rs Removed clap-verbosity-flag dependency
sync-server/Cargo.toml Removed clap-verbosity-flag from dependencies
sync-server/src/utils/rotating_file_writer.rs Added test cleanup to prevent interference between tests
frontend/sync-client/src/utils/data-structures/event-listeners.ts New EventListeners utility class for managing event subscriptions
frontend/sync-client/src/utils/remove-from-array.ts New helper function for efficient array item removal
frontend/sync-client/src/tracing/logger.ts Refactored to use EventListeners class
frontend/sync-client/src/sync-client.ts Exposed event listeners as public getters
frontend/local-client-cli/src/file-watcher.ts Replaced fs.watch with watcher package for better rename detection
frontend/package.json Changed from tabs to spaces and added eclint
scripts/check.sh Added eclint fix step to enforce editor config
docs/architecture/data-flow.md Fixed ASCII diagram formatting
.editorconfig Added markdown to indent configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

## Pull request overview This PR refactors event listener management throughout the codebase by introducing a reusable `EventListeners` class, removes the `clap-verbosity-flag` dependency in favor of a custom `LogLevel` enum, and includes various code quality improvements such as fixing indentation, adding test cleanup, and improving file watching in the CLI. **Key Changes:** - Introduced `EventListeners` utility class to standardize event listener management across the codebase - Replaced `clap-verbosity-flag` with custom `LogLevel` enum for better control over logging configuration - Updated file watcher implementation to use the `watcher` package for more reliable file system monitoring ### Reviewed changes Copilot reviewed 51 out of 168 changed files in this pull request and generated 7 comments. <details> <summary>Show a summary per file</summary> | File | Description | | ---- | ----------- | | sync-server/src/utils/log_level.rs | New LogLevel enum with conversion to tracing levels | | sync-server/src/config/logging_config.rs | Added log_level field to configuration with default value | | sync-server/src/main.rs | Updated to use LogLevel from config instead of CLI args | | sync-server/src/cli/args.rs | Removed clap-verbosity-flag dependency | | sync-server/Cargo.toml | Removed clap-verbosity-flag from dependencies | | sync-server/src/utils/rotating_file_writer.rs | Added test cleanup to prevent interference between tests | | frontend/sync-client/src/utils/data-structures/event-listeners.ts | New EventListeners utility class for managing event subscriptions | | frontend/sync-client/src/utils/remove-from-array.ts | New helper function for efficient array item removal | | frontend/sync-client/src/tracing/logger.ts | Refactored to use EventListeners class | | frontend/sync-client/src/sync-client.ts | Exposed event listeners as public getters | | frontend/local-client-cli/src/file-watcher.ts | Replaced fs.watch with watcher package for better rename detection | | frontend/package.json | Changed from tabs to spaces and added eclint | | scripts/check.sh | Added eclint fix step to enforce editor config | | docs/architecture/data-flow.md | Fixed ASCII diagram formatting | | .editorconfig | Added markdown to indent configuration | </details> --- 💡 <a href="/schmelczer/vault-link/new/main/.github/instructions?filename=*.instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how to get started</a>.
.github/workflows/e2e.yml
@ -6,7 +6,7 @@ on:
pull_request:
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2025-12-07 16:40:44 +00:00
Copy link

The cron schedule * * * * * runs every minute, which is very frequent for E2E tests. This will consume significant CI resources. Consider if this frequency is intentional compared to the previous */30 * * * * (every 30 minutes).

    - cron: '*/30 * * * *'
The cron schedule `* * * * *` runs every minute, which is very frequent for E2E tests. This will consume significant CI resources. Consider if this frequency is intentional compared to the previous `*/30 * * * *` (every 30 minutes). ```suggestion - cron: '*/30 * * * *' ```
docs/architecture/data-flow.md
@ -143,1 +140,4 @@
│ }
│
▼
┌─────────┐
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2025-12-07 16:40:43 +00:00
Copy link

Inconsistent ASCII art formatting. The line should use consistent dashes: └───┬────┘ instead of └───┬─-───┘.

└───┬────┘
Inconsistent ASCII art formatting. The line should use consistent dashes: `└───┬────┘` instead of `└───┬─-───┘`. ```suggestion └───┬────┘ ```
docs/architecture/data-flow.md
@ -177,0 +171,4 @@
│ type: "file_updated",
│ path: "notes/daily.md",
│ version: 43
│ }
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2025-12-07 16:40:43 +00:00
Copy link

Inconsistent ASCII art formatting. The line should use consistent dashes: └───┬────┘ instead of └───┬────-┘.

└───┬────┘
Inconsistent ASCII art formatting. The line should use consistent dashes: `└───┬────┘` instead of `└───┬────-┘`. ```suggestion └───┬────┘ ```
docs/architecture/data-flow.md
@ -206,1 +204,3 @@
└────┬────┘
┌─────────┐
│ Client │
└───-─┬───┘
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2025-12-07 16:40:44 +00:00
Copy link

Inconsistent ASCII art formatting. The line should use consistent dashes: └───┬────┘ instead of └───┬─-───┘.

Inconsistent ASCII art formatting. The line should use consistent dashes: `└───┬────┘` instead of `└───┬─-───┘`.
docs/architecture/data-flow.md
@ -233,3 +230,1 @@
├─► 4. Broadcast deletion
│
└─► 5. ACK to sender
│ 3. Mark as deleted in DB
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2025-12-07 16:40:44 +00:00
Copy link

Inconsistent ASCII art formatting. The line should use consistent dashes: └───┬────┘ instead of └───┬─-───┘.

└───┬────┘
Inconsistent ASCII art formatting. The line should use consistent dashes: `└───┬────┘` instead of `└───┬─-───┘`. ```suggestion └───┬────┘ ```
docs/architecture/data-flow.md
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2025-12-07 16:40:44 +00:00
Copy link

Inconsistent ASCII art formatting. The line should use consistent dashes: └───┬────┘ instead of └───┬─=───┘.

Inconsistent ASCII art formatting. The line should use consistent dashes: `└───┬────┘` instead of `└───┬─=───┘`.
docs/architecture/data-flow.md
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2025-12-07 16:40:44 +00:00
Copy link

Inconsistent ASCII art formatting. The line should use consistent dashes: └────┬───┘ instead of └───-─┬───┘.

    └────┬───┘
Inconsistent ASCII art formatting. The line should use consistent dashes: `└────┬───┘` instead of `└───-─┬───┘`. ```suggestion └────┬───┘ ```
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
docker

Pull requests that update docker code

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
javascript

Pull requests that update javascript code

  
question

Further information is requested

  
rust

Pull requests that update rust code

  
wontfix

This will not be worked on

No labels
bug
dependencies
docker
documentation
duplicate
enhancement
good first issue
help wanted
invalid
javascript
question
rust
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: andras/vault-link#179
No description provided.
Delete branch "asch/refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?