andras/vault-link
andras/vault-link
1
0
Fork 0
Code Issues Pull requests 19 Projects Releases 55 Packages Wiki Activity Actions 25

Various improvements #169

Merged
schmelczer merged 78 commits from asch/saturday into main 2025-11-30 15:24:52 +00:00
Conversation 2 Commits 78 Files changed 112 +3 -2
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 29784eb600 - Show all commits

Use named group

Prev Next
Andras Schmelczer 2025-11-28 21:23:55 +00:00
commit 29784eb600

5
frontend/sync-client/src/file-operations/file-operations.ts
View file

@ -9,7 +9,7 @@ import { isBinary } from "../utils/is-binary";
import type { ServerConfig } from "../services/server-config"; import type { ServerConfig } from "../services/server-config";
export class FileOperations { export class FileOperations {
private static readonly PARENTHESES_REGEX = / \((\d+)\)$/; private static readonly PARENTHESES_REGEX = / \((?<count>\d+)\)$/;
private readonly fs: SafeFileSystemOperations; private readonly fs: SafeFileSystemOperations;
copilot-pull-request-reviewer[bot] commented 2025-11-30 15:03:03 +00:00 (Migrated from github.com)
Copy link

[nitpick] The named capture group is called 'count' but is accessed as 'groups?.count' in the code at line 265. For consistency with the previous code that used groups?.[0], consider either keeping the array access pattern or updating the comment to explain the named group convention.

[nitpick] The named capture group is called 'count' but is accessed as 'groups?.count' in the code at line 265. For consistency with the previous code that used groups?.[0], consider either keeping the array access pattern or updating the comment to explain the named group convention.
public constructor( public constructor(
@ -251,7 +251,8 @@ export class FileOperations {
: ""; : "";
let stem = extension ? nameParts.slice(0, -1).join(".") : fileName; let stem = extension ? nameParts.slice(0, -1).join(".") : fileName;
let currentCount = Number.parseInt( let currentCount = Number.parseInt(
FileOperations.PARENTHESES_REGEX.exec(stem)?.[1] ?? "0" FileOperations.PARENTHESES_REGEX.exec(stem)?.groups?.["count"] ??
"0"
); );
stem = stem.replace(FileOperations.PARENTHESES_REGEX, ""); stem = stem.replace(FileOperations.PARENTHESES_REGEX, "");