andras/vault-link
1
0
Fork 0
Code Issues Pull requests 18 Projects Releases 55 Packages Wiki Activity Actions 1

Clean up deterministic tests

Browse source
This commit is contained in:
Andras Schmelczer 2026-03-28 11:12:43 +00:00
parent 7b9287ca52
commit f36a84b275
113 changed files with 1366 additions and 3835 deletions
Download patch file Download diff file Expand all files Collapse all files

56
frontend/deterministic-tests/src/tests/offline-move-then-remote-delete.test.ts
View file

@ -1,44 +1,11 @@
import type { ClientState, TestDefinition } from "../test-definition";
import { assert } from "../utils/assert";
/**
* BUG: Move + remote-delete coalescing uses stale source path.
*
* Found by: multi-client convergence agent (#10)
*
* When a local move and a remote-delete are coalesced for the same document:
* move(A→B) + remote-delete = delete(path: A)
* (sync-events.ts line 210-211)
*
* But the VFS has already moved the document from A to B (syncer.ts
* line 152 runs vfs.move() immediately on the local-move event).
* When the executor tries to find the document at path A (line 302
* in syncer.ts), it returns undefined because D1 is now at path B.
* The delete is silently skipped.
*
* The system should recover via runFinalConsistencyCheck() or the next
* reconciliation cycle, which will detect that B.md exists on disk
* but the server says D1 is deleted.
*
* This test verifies that both clients converge — the file should end
* up deleted on both clients.
*/
function verifyNoFiles(state: ClientState): void {
assert(
state.files.size === 0,
`Expected 0 files, got ${state.files.size}: ${Array.from(state.files.keys()).join(", ")}`
);
}
import type { TestDefinition } from "../test-definition";
export const offlineMoveThenRemoteDeleteTest: TestDefinition = {
name: "Offline Move + Remote Delete Convergence",
description:
"Client 0 renames A→B offline while Client 1 deletes A. " +
"The move+delete coalescing may use a stale path. " +
"Both clients should converge to having no files.",
"Client 0 renames A.md to B.md offline while client 1 deletes A.md. " +
"Both clients must converge to having no files.",
clients: 2,
steps: [
// Setup: both have A.md
{
type: "create",
client: 0,
@ -50,24 +17,23 @@ export const offlineMoveThenRemoteDeleteTest: TestDefinition = {
{ type: "sync" },
{ type: "barrier" },
// Client 0 goes offline, renames A→B
{ type: "disable-sync", client: 0 },
{ type: "rename", client: 0, oldPath: "A.md", newPath: "B.md" },
// Client 1 deletes A.md (broadcasts to server)
{ type: "delete", client: 1, path: "A.md" },
{ type: "sync", client: 1 },
// Client 0 reconnects — receives remote-delete while move is pending
{ type: "enable-sync", client: 0 },
{ type: "sync" },
{ type: "barrier" },
// Both should converge to no files
{ type: "assert-not-exists", client: 0, path: "A.md" },
{ type: "assert-not-exists", client: 1, path: "A.md" },
{ type: "assert-not-exists", client: 0, path: "B.md" },
{ type: "assert-not-exists", client: 1, path: "B.md" },
{ type: "assert-consistent", verify: verifyNoFiles }
{
type: "assert-consistent",
verify: (s) =>
s
.assertFileNotExists("A.md")
.assertFileNotExists("B.md")
.assertFileCount(0)
}
]
};