Remove isNewFile

frontend/deterministic-tests/src/tests/catchup-create-and-update-not-skipped.test.ts

@@ -5,14 +5,12 @@ export const catchupCreateAndUpdateNotSkippedTest: TestDefinition = {
     description:
         "Client 1 disconnects (sync disabled). Client 0 creates a doc and " +
         "then updates it. When Client 1 reconnects, the server's catch-up " +
-        "stream sends only the doc's *latest* version (the update), not the " +
-        "full history. Pre-fix the wire's `is_new_file` was set to " +
-        "`creation == latest_version`, so the catch-up flagged the doc as " +
-        "non-new even though Client 1 had never seen its creation. Client " +
-        "1's `processRemoteChange` then dropped it as a 'stale RemoteChange " +
-        "for untracked, non-new document' and the doc was silently lost. " +
-        "Post-fix `is_new_file` in the catch-up stream means 'new relative " +
-        "to the recipient's watermark' (`creation > last_seen_vault_update_id`).",
+        "stream sends only the doc's *latest* version (the update), not " +
+        "the full history. Client 1 must still pick up the doc — any handler " +
+        "that gates the create-on-untracked path on a server-supplied " +
+        "'is this the first version' flag would drop it (the latest version " +
+        "is not the create), silently leaking the doc. The client treats " +
+        "every untracked-doc RemoteChange as a fresh create.",
     clients: 2,
     steps: [
         { type: "enable-sync", client: 0 },
@@ -36,7 +34,7 @@ export const catchupCreateAndUpdateNotSkippedTest: TestDefinition = {
 
         // Client 0 updates the doc (vault_update_id v_X > v_C). The
         // server's `latest_document_versions` view now returns the
-        // *update* row — its `creation_vault_update_id != vault_update_id`.
+        // *update* row — the create row is no longer the latest.
         {
             type: "update",
             client: 0,
@@ -46,10 +44,9 @@ export const catchupCreateAndUpdateNotSkippedTest: TestDefinition = {
         { type: "sync", client: 0 },
 
         // Client 1 reconnects. Server's catch-up replays docs with
-        // `vault_update_id > last_seen`. For doc.md it sends v_X with
-        // `is_new_file` derived from `creation_vault_update_id >
-        // last_seen_vault_update_id` (post-fix) — so Client 1 treats it
-        // as a fresh create and downloads the latest content.
+        // `vault_update_id > last_seen`. For doc.md it sends v_X; Client
+        // 1 has no record of the doc, so it treats the RemoteChange as a
+        // fresh create and downloads the latest content.
         { type: "enable-sync", client: 1 },
         { type: "barrier" },
 

frontend/sync-client/src/services/types/DocumentVersionWithoutContent.ts

@@ -9,8 +9,4 @@ export interface DocumentVersionWithoutContent {
     userId: string;
     deviceId: string;
     contentSize: number;
-    /**
-     * True iff this is the first version of the document
-     */
-    isNewFile: boolean;
 }

frontend/sync-client/src/sync-operations/sync-event-queue.test.ts

@@ -66,7 +66,6 @@ function fakeRemoteVersion(
         userId: "user",
         deviceId: "device",
         contentSize: 100,
-        isNewFile: true,
         ...overrides
     };
 }

frontend/sync-client/src/sync-operations/sync-event-queue.ts

@@ -618,9 +618,8 @@ export class SyncEventQueue {
         // in the queue ahead of it. Once those drain and the doc is
         // removed, a still-pending RemoteChange for an earlier version
         // would be processed by `processRemoteCreateForNewDocument` (the
-        // doc is now untracked, and catch-up's `isNewFile=true` semantics
-        // qualify it as a fresh create), resurrecting the doc on disk
-        // with stale bytes that disagree with every other agent.
+        // doc is now untracked), resurrecting the doc on disk with stale
+        // bytes that disagree with every other agent.
         this.purgeRemoteChangesForDocumentId(documentId);
         return this.save();
     }

frontend/sync-client/src/sync-operations/syncer.ts

@@ -703,8 +703,7 @@ export class Syncer {
         if (response.isDeleted) {
             await this.processRemoteDelete(record.localPath, {
                 ...response,
-                contentSize: 0,
-                isNewFile: false
+                contentSize: 0
             });
             return;
         }
@@ -859,14 +858,6 @@ export class Syncer {
             return this.processRemoteUpdate(trackedRecord, remoteVersion);
         }
 
-        if (!remoteVersion.isNewFile) {
-            this.queue.lastSeenUpdateId = remoteVersion.vaultUpdateId;
-            this.logger.debug(
-                `Ignoring stale RemoteChange for untracked, non-new document ${remoteVersion.documentId}`
-            );
-            return;
-        }
-
         return this.processRemoteCreateForNewDocument(remoteVersion);
     }