Improve comments

frontend/sync-client/src/sync-operations/cursor-tracker.ts

@@ -149,7 +149,7 @@ export class CursorTracker {
 	public addRemoteCursorsUpdateListener(
 		listener: (cursors: MaybeOutdatedClientCursors[]) => unknown
 	): void {
-		// CursorTracker registers its own event listener in the constructor so it must get called first
+		// CursorTracker registers its own event listener in the constructor so it must have been called before this
 		this.webSocketManager.addRemoteCursorsUpdateListener(async () => {
 			await this.updateLock.withLock(() =>
 				listener(this.getRelevantAndPruneKnownClientCursors())

scripts/check.sh

@@ -9,19 +9,19 @@ cargo fmt --all -- --check
 cargo machete
 cargo test --verbose
 
-
 echo "Running checks in frontend"
 cd ../frontend
 npm ci
 npm run build
 npm run lint
+npm run test
+
 if [[ $(git status --porcelain) ]]; then
     git status --porcelain
     echo "Failing CI because the working directory is not clean after linting"
     exit 1
 fi
-npm run test
 
-echo "Finished"
+echo "Success"
 
 cd ..

sync-server/src/app_state/websocket/models.rs

@@ -23,7 +23,11 @@ pub struct CursorPositionFromClient {
 
 #[derive(TS, Serialize, Deserialize, Clone, Debug)]
 pub struct DocumentWithCursors {
-    // It's None in case the document is dirty
+    // It's None in case the document is dirty.
+    // We still want to sync the cursor to mark
+    // that it exists and can be client-side
+    // interpolated. However, the actual
+    // position is meaningless.
     #[ts(as = "Option<u32>")]
     pub vault_update_id: Option<VaultUpdateId>,