Use unknown return type for callbacks

frontend/obsidian-plugin/src/vault-link-plugin.ts

@@ -120,7 +120,7 @@ export default class VaultLinkPlugin extends Plugin {
 
 		this.app.workspace.onLayoutReady(async () => {
 			this.registerEditorEvents();
-			void this.client.start();
+			await this.client.start();
 
 			const interval = setInterval(() => {
 				updateEditorStatusDisplay(this.app.workspace, this.client);

frontend/obsidian-plugin/src/views/cursors/update-selection.ts

@@ -14,7 +14,7 @@ export const updateSelection = ({
 }): void => {
 	spans.forEach((span) => {
 		if (fromA <= span.start) {
-			// The change covers the entirety of the selection
+			// the change covers the entirety of the selection
 			if (toA > span.end) {
 				span.start = toB;
 				span.end = toB;
@@ -23,6 +23,8 @@ export const updateSelection = ({
 
 			let change = toB - toA;
 			if (change < 0) {
+				// it's a deletion
+				// if overlaps with the start, we can't move it back more than the deleted range
 				change = Math.max(change, fromA - span.start);
 			}
 
@@ -31,6 +33,7 @@ export const updateSelection = ({
 		} else if (toA <= span.end) {
 			span.end += toB - toA;
 		} else if (toB <= span.end) {
+			// a deletion overlaps with the end, so we move the end
 			span.end = toB;
 		}
 	});

frontend/obsidian-plugin/src/views/history/history-view.ts

@@ -24,13 +24,12 @@ export class HistoryView extends ItemView {
 		super(leaf);
 		this.icon = HistoryView.ICON;
 
-		this.client.addSyncHistoryUpdateListener(
+		this.client.addSyncHistoryUpdateListener(async () =>
-			() =>
+			this.updateView().catch((error: unknown) => {
-				void this.updateView().catch((error: unknown) => {
+				this.client.logger.error(
-					this.client.logger.error(
+					`Failed to update history view: ${error}`
-						`Failed to update history view: ${error}`
+				);
-					);
+			})
-				})
 		);
 	}
 
@@ -109,7 +108,15 @@ export class HistoryView extends ItemView {
 		this.historyContainer = container.createDiv({ cls: "logs-container" });
 
 		await this.updateView();
-		this.timer = setInterval(() => void this.updateView(), 1000);
+		this.timer = setInterval(
+			() =>
+				void this.updateView().catch((error: unknown) => {
+					this.client.logger.error(
+						`Failed to update history view: ${error}`
+					);
+				}),
+			1000
+		);
 	}
 
 	public async onClose(): Promise<void> {
@@ -174,11 +181,17 @@ export class HistoryView extends ItemView {
 					null
 				) {
 					card.addEventListener("click", () => {
-						void this.app.workspace.openLinkText(
+						this.app.workspace
-							entry.details.relativePath,
+							.openLinkText(
-							entry.details.relativePath,
+								entry.details.relativePath,
-							false
+								entry.details.relativePath,
-						);
+								false
+							)
+							.catch((error: unknown) => {
+								this.client.logger.error(
+									`Failed to open link for ${entry.details.relativePath}: ${error}`
+								);
+							});
 					});
 
 					card.addClass("clickable");

frontend/obsidian-plugin/src/views/settings/settings-tab.ts

@@ -16,7 +16,7 @@ export class SyncSettingsTab extends PluginSettingTab {
 	private readonly plugin: VaultLinkPlugin;
 	private readonly syncClient: SyncClient;
 	private readonly statusDescription: StatusDescription;
-	private statusDescriptionSubscription: (() => void) | undefined;
+	private statusDescriptionSubscription: (() => unknown) | undefined;
 
 	public constructor({
 		app,
@@ -90,11 +90,12 @@ export class SyncSettingsTab extends PluginSettingTab {
 				cls: "description"
 			},
 			(descriptionContainer) => {
-				this.setStatusDescriptionSubscription((): void => {
+				this.setStatusDescriptionSubscription(
-					this.statusDescription.renderStatusDescription(
+					this.statusDescription.renderStatusDescription.bind(
+						this.statusDescription,
 						descriptionContainer
-					);
+					)
-				});
+				);
 			}
 		);
 
@@ -339,7 +340,7 @@ export class SyncSettingsTab extends PluginSettingTab {
 	}
 
 	private setStatusDescriptionSubscription(
-		newSubscription?: () => void
+		newSubscription?: () => unknown
 	): void {
 		if (this.statusDescriptionSubscription) {
 			this.statusDescription.removeStatusChangeListener(
@@ -360,7 +361,7 @@ export class SyncSettingsTab extends PluginSettingTab {
 		settingName: keyof SyncSettings
 	): [
 		DocumentFragment,
-		(newValue: SyncSettings[keyof SyncSettings]) => void
+		(newValue: SyncSettings[keyof SyncSettings]) => unknown
 	] {
 		const titleContainer = document.createDocumentFragment();
 		const title = titleContainer.createEl("div", {

frontend/obsidian-plugin/src/views/status-bar/status-bar.ts

@@ -42,9 +42,7 @@ export class StatusBar {
 				text: "VaultLink is disabled, click to configure",
 				cls: "initialize-button"
 			});
-			button.onclick = (): void => {
+			button.onclick = this.plugin.openSettings.bind(this.plugin);
-				this.plugin.openSettings();
-			};
 
 			return;
 		}

frontend/obsidian-plugin/src/views/status-description/status-description.ts

@@ -28,12 +28,12 @@ export class StatusDescription {
 			}
 		);
 
-		this.syncClient.addWebSocketStatusChangeListener(
+		this.syncClient.addWebSocketStatusChangeListener(async () =>
-			() => void this.updateConnectionState()
+			this.updateConnectionState()
 		);
 
-		this.syncClient.addOnSettingsChangeListener(
+		this.syncClient.addOnSettingsChangeListener(async () =>
-			() => void this.updateConnectionState()
+			this.updateConnectionState()
 		);
 	}
 
@@ -42,10 +42,10 @@ export class StatusDescription {
 		this.updateDescription();
 	}
 
-	public addStatusChangeListener(listener: () => void): void {
+	public addStatusChangeListener(listener: () => unknown): void {
 		this.statusChangeListeners.push(listener);
 	}
-	public removeStatusChangeListener(listener: () => void): void {
+	public removeStatusChangeListener(listener: () => unknown): void {
 		this.statusChangeListeners = this.statusChangeListeners.filter(
 			(l) => l !== listener
 		);

frontend/sync-client/src/persistence/database.ts

@@ -331,6 +331,8 @@ export class Database {
 			),
 			lastSeenUpdateId: this.lastSeenUpdateIds.min,
 			hasInitialSyncCompleted: this.hasInitialSyncCompleted
+		}).catch((error: unknown) => {
+			this.logger.error(`Error saving data: ${error}`);
 		});
 	}
 

frontend/sync-client/src/persistence/settings.ts

@@ -28,7 +28,7 @@ export class Settings {
 	private readonly onSettingsChangeHandlers: ((
 		newSettings: SyncSettings,
 		oldSettings: SyncSettings
-	) => void)[] = [];
+	) => unknown)[] = [];
 
 	public constructor(
 		private readonly logger: Logger,
@@ -50,7 +50,7 @@ export class Settings {
 	}
 
 	public addOnSettingsChangeListener(
-		handler: (settings: SyncSettings, oldSettings: SyncSettings) => void
+		handler: (settings: SyncSettings, oldSettings: SyncSettings) => unknown
 	): void {
 		this.onSettingsChangeHandlers.push(handler);
 	}

frontend/sync-client/src/services/connection-status.ts

@@ -7,8 +7,8 @@ export class ConnectionStatus {
 	private static readonly UNTIL_RESOLUTION = Symbol();
 	private canFetch: boolean;
 	private until: Promise<symbol>;
-	private resolveUntil: (result: symbol) => void;
+	private resolveUntil: (result: symbol) => unknown;
-	private rejectUntil: (reason: unknown) => void;
+	private rejectUntil: (reason: unknown) => unknown;
 
 	public constructor(
 		settings: Settings,

frontend/sync-client/src/services/websocket-manager.ts

@@ -64,12 +64,12 @@ export class WebSocketManager {
 		);
 	}
 
-	public addWebSocketStatusChangeListener(listener: () => void): void {
+	public addWebSocketStatusChangeListener(listener: () => unknown): void {
 		this.webSocketStatusChangeListeners.push(listener);
 	}
 
 	public addRemoteCursorsUpdateListener(
-		listener: (cursors: ClientCursors[]) => void
+		listener: (cursors: ClientCursors[]) => unknown
 	): void {
 		this.remoteCursorsUpdateListeners.push(listener);
 	}

frontend/sync-client/src/sync-client.ts

@@ -48,9 +48,9 @@ export class SyncClient {
 		private readonly fileOperations: FileOperations
 	) {
 		this.settings.addOnSettingsChangeListener(
-			(newSettings, oldSettings) => {
+			async (newSettings, oldSettings) => {
 				if (newSettings.vaultName !== oldSettings.vaultName) {
-					void this.reset();
+					await this.reset();
 				}
 			}
 		);
@@ -197,7 +197,7 @@ export class SyncClient {
 	}
 
 	public addSyncHistoryUpdateListener(
-		listener: (stats: HistoryStats) => void
+		listener: (stats: HistoryStats) => unknown
 	): void {
 		this.history.addSyncHistoryUpdateListener(listener);
 	}
@@ -227,7 +227,7 @@ export class SyncClient {
 		this.database.reset();
 		this._logger.reset();
 		this.connectionStatus.finishReset();
-		void this.start();
+		await this.start();
 	}
 
 	public getSettings(): SyncSettings {
@@ -246,18 +246,18 @@ export class SyncClient {
 	}
 
 	public addOnSettingsChangeListener(
-		handler: (settings: SyncSettings, oldSettings: SyncSettings) => void
+		handler: (settings: SyncSettings, oldSettings: SyncSettings) => unknown
 	): void {
 		this.settings.addOnSettingsChangeListener(handler);
 	}
 
 	public addRemainingSyncOperationsListener(
-		listener: (remainingOperations: number) => void
+		listener: (remainingOperations: number) => unknown
 	): void {
 		this.syncer.addRemainingOperationsListener(listener);
 	}
 
-	public addWebSocketStatusChangeListener(listener: () => void): void {
+	public addWebSocketStatusChangeListener(listener: () => unknown): void {
 		this.webSocketManager.addWebSocketStatusChangeListener(listener);
 	}
 
@@ -344,7 +344,7 @@ export class SyncClient {
 	}
 
 	public addRemoteCursorsUpdateListener(
-		listener: (cursors: DocumentWithMaybeOutdatedClientCursors[]) => void
+		listener: (cursors: DocumentWithMaybeOutdatedClientCursors[]) => unknown
 	): void {
 		this.webSocketManager.addRemoteCursorsUpdateListener(async () => {
 			listener(await this.getRelevantClientCursors());

frontend/sync-client/src/sync-operations/syncer.ts

@@ -22,7 +22,7 @@ export class Syncer {
 	private readonly remoteDocumentsLock: Locks<DocumentId>;
 	private readonly remainingOperationsListeners: ((
 		remainingOperations: number
-	) => void)[] = [];
+	) => unknown)[] = [];
 	private readonly syncQueue: PQueue;
 
 	private runningScheduleSyncForOfflineChanges: Promise<void> | undefined;
@@ -57,7 +57,7 @@ export class Syncer {
 	}
 
 	public addRemainingOperationsListener(
-		listener: (remainingOperations: number) => void
+		listener: (remainingOperations: number) => unknown
 	): void {
 		this.remainingOperationsListeners.push(listener);
 	}

frontend/sync-client/src/tracing/logger.ts

@@ -23,9 +23,11 @@ export class LogLine {
 export class Logger {
 	private static readonly MAX_MESSAGES = 100000;
 	private readonly messages: LogLine[] = [];
-	private readonly onMessageListeners: ((message: LogLine) => void)[] = [];
+	private readonly onMessageListeners: ((message: LogLine) => unknown)[] = [];
 
-	public constructor(...onMessageListeners: ((message: LogLine) => void)[]) {
+	public constructor(
+		...onMessageListeners: ((message: LogLine) => unknown)[]
+	) {
 		this.onMessageListeners = onMessageListeners;
 	}
 
@@ -53,7 +55,7 @@ export class Logger {
 		);
 	}
 
-	public addOnMessageListener(listener: (message: LogLine) => void): void {
+	public addOnMessageListener(listener: (message: LogLine) => unknown): void {
 		this.onMessageListeners.push(listener);
 	}
 

frontend/sync-client/src/tracing/sync-history.ts

@@ -70,7 +70,7 @@ export class SyncHistory {
 
 	private readonly syncHistoryUpdateListeners: ((
 		status: HistoryStats
-	) => void)[] = [];
+	) => unknown)[] = [];
 
 	private status: HistoryStats = {
 		success: 0,
@@ -111,7 +111,7 @@ export class SyncHistory {
 	}
 
 	public addSyncHistoryUpdateListener(
-		listener: (stats: HistoryStats) => void
+		listener: (stats: HistoryStats) => unknown
 	): void {
 		this.syncHistoryUpdateListeners.push(listener);
 		listener({ ...this.status });

frontend/sync-client/src/utils/create-promise.ts

@@ -2,13 +2,13 @@
  * A type-safe utility function to create a Promise with resolve and reject functions.
  * @returns A tuple containing a Promise, a resolve function, and a reject function.
  */
-export function createPromise<T = void>(): [
+export function createPromise<T = unknown>(): [
 	Promise<T>,
-	(value: T) => void,
+	(value: T) => unknown,
-	(error: unknown) => void
+	(error: unknown) => unknown
 ] {
-	let resolve: undefined | ((resolved: T) => void) = undefined;
+	let resolve: undefined | ((resolved: T) => unknown) = undefined;
-	let reject: undefined | ((error: unknown) => void) = undefined;
+	let reject: undefined | ((error: unknown) => unknown) = undefined;
 
 	const creationPromise = new Promise<T>(
 		(resolve_, reject_) => ((resolve = resolve_), (reject = reject_))

frontend/test-client/src/agent/mock-client.ts

@@ -37,7 +37,7 @@ export class MockClient implements FileSystemOperations {
 			fs: this,
 			persistence: {
 				load: async () => this.data,
-				save: async (data) => void (this.data = data)
+				save: async (data) => (this.data = data)
 			},
 			fetch: fetchImplementation,
 			webSocket: webSocketImplementation
@@ -78,9 +78,9 @@ export class MockClient implements FileSystemOperations {
 		);
 		this.localFiles.set(path, newContent);
 
-		this.executeFileOperation(() => {
+		this.executeFileOperation(async () =>
-			void this.client.syncLocallyCreatedFile(path);
+			this.client.syncLocallyCreatedFile(path)
-		});
+		);
 	}
 
 	public async createDirectory(_path: RelativePath): Promise<void> {
@@ -120,11 +120,11 @@ export class MockClient implements FileSystemOperations {
 			`Updated file ${path} with:\n  current content: ${currentContent}\n  new content: ${newContent}`
 		);
 
-		this.executeFileOperation(() => {
+		this.executeFileOperation(async () =>
-			void this.client.syncLocallyUpdatedFile({
+			this.client.syncLocallyUpdatedFile({
 				relativePath: path
-			});
+			})
-		});
+		);
 
 		return newContent;
 	}
@@ -137,13 +137,13 @@ export class MockClient implements FileSystemOperations {
 			`Updated file ${path} with:\n  new content: ${new TextDecoder().decode(content)}`
 		);
 
-		this.executeFileOperation(() => {
+		this.executeFileOperation(async () => {
 			if (hasExisted) {
-				void this.client.syncLocallyUpdatedFile({
+				return this.client.syncLocallyUpdatedFile({
 					relativePath: path
 				});
 			} else {
-				void this.client.syncLocallyCreatedFile(path);
+				return this.client.syncLocallyCreatedFile(path);
 			}
 		});
 	}
@@ -154,9 +154,9 @@ export class MockClient implements FileSystemOperations {
 		);
 		this.localFiles.delete(path);
 
-		this.executeFileOperation(() => {
+		this.executeFileOperation(async () =>
-			void this.client.syncLocallyDeletedFile(path);
+			this.client.syncLocallyDeletedFile(path)
-		});
+		);
 	}
 
 	public async rename(
@@ -176,15 +176,15 @@ export class MockClient implements FileSystemOperations {
 			`Renamed file: ${oldPath} -> ${newPath} with:\n  content ${new TextDecoder().decode(file)}`
 		);
 
-		this.executeFileOperation(() => {
+		this.executeFileOperation(async () =>
-			void this.client.syncLocallyUpdatedFile({
+			this.client.syncLocallyUpdatedFile({
 				oldPath,
 				relativePath: newPath
-			});
+			})
-		});
+		);
 	}
 
-	private executeFileOperation(callback: () => void): void {
+	private executeFileOperation(callback: () => unknown): void {
 		if (this.useSlowFileEvents) {
 			// we aren't the best client and it takes some time to notice changes
 			setTimeout(callback, Math.random() * 100);