Use unknown return type for callbacks

frontend/sync-client/src/persistence/database.ts

@@ -331,6 +331,8 @@ export class Database {
 			),
 			lastSeenUpdateId: this.lastSeenUpdateIds.min,
 			hasInitialSyncCompleted: this.hasInitialSyncCompleted
+		}).catch((error: unknown) => {
+			this.logger.error(`Error saving data: ${error}`);
 		});
 	}
 

frontend/sync-client/src/persistence/settings.ts

@@ -28,7 +28,7 @@ export class Settings {
 	private readonly onSettingsChangeHandlers: ((
 		newSettings: SyncSettings,
 		oldSettings: SyncSettings
-	) => void)[] = [];
+	) => unknown)[] = [];
 
 	public constructor(
 		private readonly logger: Logger,
@@ -50,7 +50,7 @@ export class Settings {
 	}
 
 	public addOnSettingsChangeListener(
-		handler: (settings: SyncSettings, oldSettings: SyncSettings) => void
+		handler: (settings: SyncSettings, oldSettings: SyncSettings) => unknown
 	): void {
 		this.onSettingsChangeHandlers.push(handler);
 	}

frontend/sync-client/src/services/connection-status.ts

@@ -7,8 +7,8 @@ export class ConnectionStatus {
 	private static readonly UNTIL_RESOLUTION = Symbol();
 	private canFetch: boolean;
 	private until: Promise<symbol>;
-	private resolveUntil: (result: symbol) => void;
-	private rejectUntil: (reason: unknown) => void;
+	private resolveUntil: (result: symbol) => unknown;
+	private rejectUntil: (reason: unknown) => unknown;
 
 	public constructor(
 		settings: Settings,

frontend/sync-client/src/services/websocket-manager.ts

@@ -64,12 +64,12 @@ export class WebSocketManager {
 		);
 	}
 
-	public addWebSocketStatusChangeListener(listener: () => void): void {
+	public addWebSocketStatusChangeListener(listener: () => unknown): void {
 		this.webSocketStatusChangeListeners.push(listener);
 	}
 
 	public addRemoteCursorsUpdateListener(
-		listener: (cursors: ClientCursors[]) => void
+		listener: (cursors: ClientCursors[]) => unknown
 	): void {
 		this.remoteCursorsUpdateListeners.push(listener);
 	}

frontend/sync-client/src/sync-client.ts

@@ -48,9 +48,9 @@ export class SyncClient {
 		private readonly fileOperations: FileOperations
 	) {
 		this.settings.addOnSettingsChangeListener(
-			(newSettings, oldSettings) => {
+			async (newSettings, oldSettings) => {
 				if (newSettings.vaultName !== oldSettings.vaultName) {
-					void this.reset();
+					await this.reset();
 				}
 			}
 		);
@@ -197,7 +197,7 @@ export class SyncClient {
 	}
 
 	public addSyncHistoryUpdateListener(
-		listener: (stats: HistoryStats) => void
+		listener: (stats: HistoryStats) => unknown
 	): void {
 		this.history.addSyncHistoryUpdateListener(listener);
 	}
@@ -227,7 +227,7 @@ export class SyncClient {
 		this.database.reset();
 		this._logger.reset();
 		this.connectionStatus.finishReset();
-		void this.start();
+		await this.start();
 	}
 
 	public getSettings(): SyncSettings {
@@ -246,18 +246,18 @@ export class SyncClient {
 	}
 
 	public addOnSettingsChangeListener(
-		handler: (settings: SyncSettings, oldSettings: SyncSettings) => void
+		handler: (settings: SyncSettings, oldSettings: SyncSettings) => unknown
 	): void {
 		this.settings.addOnSettingsChangeListener(handler);
 	}
 
 	public addRemainingSyncOperationsListener(
-		listener: (remainingOperations: number) => void
+		listener: (remainingOperations: number) => unknown
 	): void {
 		this.syncer.addRemainingOperationsListener(listener);
 	}
 
-	public addWebSocketStatusChangeListener(listener: () => void): void {
+	public addWebSocketStatusChangeListener(listener: () => unknown): void {
 		this.webSocketManager.addWebSocketStatusChangeListener(listener);
 	}
 
@@ -344,7 +344,7 @@ export class SyncClient {
 	}
 
 	public addRemoteCursorsUpdateListener(
-		listener: (cursors: DocumentWithMaybeOutdatedClientCursors[]) => void
+		listener: (cursors: DocumentWithMaybeOutdatedClientCursors[]) => unknown
 	): void {
 		this.webSocketManager.addRemoteCursorsUpdateListener(async () => {
 			listener(await this.getRelevantClientCursors());

frontend/sync-client/src/sync-operations/syncer.ts

@@ -22,7 +22,7 @@ export class Syncer {
 	private readonly remoteDocumentsLock: Locks<DocumentId>;
 	private readonly remainingOperationsListeners: ((
 		remainingOperations: number
-	) => void)[] = [];
+	) => unknown)[] = [];
 	private readonly syncQueue: PQueue;
 
 	private runningScheduleSyncForOfflineChanges: Promise<void> | undefined;
@@ -57,7 +57,7 @@ export class Syncer {
 	}
 
 	public addRemainingOperationsListener(
-		listener: (remainingOperations: number) => void
+		listener: (remainingOperations: number) => unknown
 	): void {
 		this.remainingOperationsListeners.push(listener);
 	}

frontend/sync-client/src/tracing/logger.ts

@@ -23,9 +23,11 @@ export class LogLine {
 export class Logger {
 	private static readonly MAX_MESSAGES = 100000;
 	private readonly messages: LogLine[] = [];
-	private readonly onMessageListeners: ((message: LogLine) => void)[] = [];
+	private readonly onMessageListeners: ((message: LogLine) => unknown)[] = [];
 
-	public constructor(...onMessageListeners: ((message: LogLine) => void)[]) {
+	public constructor(
+		...onMessageListeners: ((message: LogLine) => unknown)[]
+	) {
 		this.onMessageListeners = onMessageListeners;
 	}
 
@@ -53,7 +55,7 @@ export class Logger {
 		);
 	}
 
-	public addOnMessageListener(listener: (message: LogLine) => void): void {
+	public addOnMessageListener(listener: (message: LogLine) => unknown): void {
 		this.onMessageListeners.push(listener);
 	}
 

frontend/sync-client/src/tracing/sync-history.ts

@@ -70,7 +70,7 @@ export class SyncHistory {
 
 	private readonly syncHistoryUpdateListeners: ((
 		status: HistoryStats
-	) => void)[] = [];
+	) => unknown)[] = [];
 
 	private status: HistoryStats = {
 		success: 0,
@@ -111,7 +111,7 @@ export class SyncHistory {
 	}
 
 	public addSyncHistoryUpdateListener(
-		listener: (stats: HistoryStats) => void
+		listener: (stats: HistoryStats) => unknown
 	): void {
 		this.syncHistoryUpdateListeners.push(listener);
 		listener({ ...this.status });

frontend/sync-client/src/utils/create-promise.ts

@@ -2,13 +2,13 @@
  * A type-safe utility function to create a Promise with resolve and reject functions.
  * @returns A tuple containing a Promise, a resolve function, and a reject function.
  */
-export function createPromise<T = void>(): [
+export function createPromise<T = unknown>(): [
 	Promise<T>,
-	(value: T) => void,
-	(error: unknown) => void
+	(value: T) => unknown,
+	(error: unknown) => unknown
 ] {
-	let resolve: undefined | ((resolved: T) => void) = undefined;
-	let reject: undefined | ((error: unknown) => void) = undefined;
+	let resolve: undefined | ((resolved: T) => unknown) = undefined;
+	let reject: undefined | ((error: unknown) => unknown) = undefined;
 
 	const creationPromise = new Promise<T>(
 		(resolve_, reject_) => ((resolve = resolve_), (reject = reject_))