andras/vault-link
1
0
Fork 0
Code Issues Pull requests 18 Projects Releases 55 Packages Wiki Activity Actions 1

Unsubscribe in SyncClient

Browse source
This commit is contained in:
Andras Schmelczer 2025-12-14 11:31:48 +00:00
parent 47f24e168b
commit 7daa363723
1 changed files with 31 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

43
frontend/sync-client/src/sync-client.ts
View file

@ -34,6 +34,8 @@ export class SyncClient {
private hasStarted = false;
private hasBeenDestroyed = false;
private unloadTelemetry?: () => void;
private isDestroying = false;
private readonly eventUnsubscribers: (() => void)[] = [];
private constructor(
private readonly history: SyncHistory,
@ -53,8 +55,9 @@ export class SyncClient {
settings: Partial<SyncSettings>;
database: Partial<StoredDatabase>;
}>
>
) {}
>,
) {
}
public get documentCount(): number {
return this.database.length;
@ -159,11 +162,6 @@ export class SyncClient {
settings.getSettings().isSyncEnabled,
logger
);
settings.onSettingsChanged.add((newSettings, oldSettings) => {
if (oldSettings.isSyncEnabled != newSettings.isSyncEnabled) {
fetchController.canFetch = newSettings.isSyncEnabled;
}
});
const syncService = new SyncService(
deviceId,
@ -258,13 +256,23 @@ export class SyncClient {
this.unloadTelemetry = setUpTelemetry();
}
this.logger.onLogEmitted.add((log): void => {
if (log.level === LogLevel.ERROR && Sentry.isInitialized()) {
Sentry.captureMessage(log.message);
this.eventUnsubscribers.push(this.settings.onSettingsChanged.add((newSettings, oldSettings) => {
if (oldSettings.isSyncEnabled != newSettings.isSyncEnabled) {
this.fetchController.canFetch = newSettings.isSyncEnabled;
}
});
}));
this.settings.onSettingsChanged.add(this.onSettingsChange.bind(this));
this.eventUnsubscribers.push(
this.logger.onLogEmitted.add((log): void => {
if (log.level === LogLevel.ERROR && Sentry.isInitialized()) {
Sentry.captureMessage(log.message);
}
})
);
this.eventUnsubscribers.push(
this.settings.onSettingsChanged.add(this.onSettingsChange.bind(this))
);
if (this.settings.getSettings().isSyncEnabled) {
this.logger.info("Starting SyncClient");
@ -431,6 +439,13 @@ export class SyncClient {
public async destroy(): Promise<void> {
this.checkIfDestroyed("destroy");
// Prevent concurrent destroy calls
if (this.isDestroying) {
this.logger.warn("destroy() called while already destroying, ignoring");
return;
}
this.isDestroying = true;
// cancel everything that's in progress
await this.pause();
@ -438,6 +453,10 @@ export class SyncClient {
this.resetInMemoryState();
// Clean up event listeners to prevent memory leaks
this.eventUnsubscribers.forEach((unsubscribe) => unsubscribe());
this.eventUnsubscribers.length = 0;
this.logger.info("SyncClient has been successfully disposed");
this.unloadTelemetry?.();