Refactor & lint

frontend/sync-client/src/sync-operations/cursor-tracker.ts

@@ -16,14 +16,14 @@ import { EventListeners } from "../utils/data-structures/event-listeners";
 // known remote cursor positions, and for each document, tries to return the latest cursor positions that are
 // not from the future.
 export class CursorTracker {
-    private readonly updateLock = new Lock();
-
     // The returned position may be accurate, if it matches the document version, or outdated, in which case
     // the client has to heuristically guess it's current position based on the local edits.
     public readonly onRemoteCursorsUpdated = new EventListeners<
         (cursors: MaybeOutdatedClientCursors[]) => unknown
     >();
 
+    private readonly updateLock = new Lock();
+
     private knownRemoteCursors: (ClientCursors & {
         upToDateness: DocumentUpToDateness;
     })[] = [];
@@ -72,7 +72,6 @@ export class CursorTracker {
             }
         );
 
-
         this.fileChangeNotifier.onFileChanged.add(async (relativePath) =>
             this.updateLock.withLock(async () => {
                 for (const clientCursor of this.knownRemoteCursors) {
@@ -156,7 +155,6 @@ export class CursorTracker {
         this.webSocketManager.updateLocalCursors({ documentsWithCursors });
     }
 
-
     public reset(): void {
         this.knownRemoteCursors = [];
         this.lastLocalCursorState = [];

frontend/sync-client/src/sync-operations/syncer.ts

@@ -24,16 +24,18 @@ import { awaitAll } from "../utils/await-all";
 import { EventListeners } from "../utils/data-structures/event-listeners";
 
 export class Syncer {
-    private readonly remoteDocumentsLock: Locks<DocumentId>;
     public readonly onRemainingOperationsCountChanged = new EventListeners<
         (remainingOperations: number) => unknown
     >();
 
+    private readonly remoteDocumentsLock: Locks<DocumentId>;
+
     // FIFO to limit the number of concurrent sync operations
     private readonly syncQueue: PQueue;
 
     private _isFirstSyncComplete = false;
     private runningScheduleSyncForOfflineChanges: Promise<void> | undefined;
+    private previousRemainingOperationsCount = 0;
 
     public constructor(
         private readonly deviceId: string,
@@ -58,17 +60,20 @@ export class Syncer {
         });
 
         this.syncQueue.on("active", () => {
-            this.onRemainingOperationsCountChanged.trigger(this.syncQueue.size);
+            if (this.previousRemainingOperationsCount !== this.syncQueue.size) {
+                this.previousRemainingOperationsCount = this.syncQueue.size;
+                this.onRemainingOperationsCountChanged.trigger(
+                    this.syncQueue.size
+                );
+            }
         });
 
-        this.webSocketManager.onWebSocketStatusChanged.add(
-            (isConnected) => {
-                if (isConnected) {
-                    // The JS WebSocket API doesn't support setting headers, so we have to send the token as a message
-                    this.sendHandshakeMessage();
-                }
+        this.webSocketManager.onWebSocketStatusChanged.add((isConnected) => {
+            if (isConnected) {
+                // The JS WebSocket API doesn't support setting headers, so we have to send the token as a message
+                this.sendHandshakeMessage();
             }
-        );
+        });
         this.webSocketManager.onRemoteVaultUpdateReceived.add(
             this.syncRemotelyUpdatedFile.bind(this)
         );
@@ -166,7 +171,7 @@ export class Syncer {
             // in that case, we mustn't move it again.
             if (
                 this.database.getLatestDocumentByRelativePath(relativePath) ===
-                undefined ||
+                    undefined ||
                 this.database.getLatestDocumentByRelativePath(relativePath)
                     ?.isDeleted === true
             ) {

frontend/sync-client/src/sync-operations/unrestricted-syncer.ts

@@ -333,7 +333,7 @@ export class UnrestrictedSyncer {
 
             const actualUpdateDetails: SyncUpdateDetails | SyncMovedDetails =
                 oldPath !== undefined ||
-                    response.relativePath != originalRelativePath
+                response.relativePath != originalRelativePath
                     ? {
                         type: SyncType.MOVE,
                         relativePath: response.relativePath,
@@ -540,8 +540,9 @@ export class UnrestrictedSyncer {
                     type: SyncType.SKIPPED,
                     relativePath
                 },
-                message: `File size of ${sizeInMB} MB exceeds the maximum file size limit of ${maxFileSizeMB
-                    } MB`
+                message: `File size of ${sizeInMB} MB exceeds the maximum file size limit of ${
+                    maxFileSizeMB
+                } MB`
             };
         }
     }