Bump eslint & lint plugin

plugin/.eslintignore

@@ -1,3 +0,0 @@
-node_modules/
-
-main.js

plugin/.eslintrc

@@ -1,23 +0,0 @@
-{
-    "root": true,
-    "parser": "@typescript-eslint/parser",
-    "env": { "node": true },
-    "plugins": [
-      "@typescript-eslint"
-    ],
-    "extends": [
-      "eslint:recommended",
-      "plugin:@typescript-eslint/eslint-recommended",
-      "plugin:@typescript-eslint/recommended"
-    ], 
-    "parserOptions": {
-        "sourceType": "module"
-    },
-    "rules": {
-      "no-unused-vars": "off",
-      "@typescript-eslint/no-unused-vars": ["error", { "args": "none" }],
-      "@typescript-eslint/ban-ts-comment": "off",
-      "no-prototype-builtins": "off",
-      "@typescript-eslint/no-empty-function": "off"
-    } 
-  }

plugin/eslint.config.mjs

@@ -0,0 +1,59 @@
+import typescriptEslint from "@typescript-eslint/eslint-plugin";
+import globals from "globals";
+import tsParser from "@typescript-eslint/parser";
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+import js from "@eslint/js";
+import { FlatCompat } from "@eslint/eslintrc";
+import unusedImports from "eslint-plugin-unused-imports";
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const compat = new FlatCompat({
+	baseDirectory: __dirname,
+	recommendedConfig: js.configs.recommended,
+	allConfig: js.configs.all,
+});
+
+export default [
+	...compat.extends(
+		"eslint:recommended",
+		"plugin:@typescript-eslint/eslint-recommended",
+		"plugin:@typescript-eslint/recommended"
+	),
+	{
+		plugins: {
+			"@typescript-eslint": typescriptEslint,
+			"unused-imports": unusedImports,
+		},
+
+		languageOptions: {
+			globals: {
+				...globals.node,
+			},
+
+			parser: tsParser,
+			ecmaVersion: 5,
+			sourceType: "module",
+		},
+
+		rules: {
+			"no-unused-vars": "off",
+			"@typescript-eslint/no-unused-vars": "off",
+			"unused-imports/no-unused-imports": "error",
+			"unused-imports/no-unused-vars": [
+				"warn",
+				{
+					vars: "all",
+					varsIgnorePattern: "^_",
+					args: "after-used",
+					argsIgnorePattern: "^_",
+				},
+			],
+
+			"@typescript-eslint/ban-ts-comment": "off",
+			"no-prototype-builtins": "off",
+			"@typescript-eslint/no-empty-function": "off",
+		},
+	},
+];

plugin/package.json

@@ -6,6 +6,7 @@
 	"scripts": {
 		"dev": "node esbuild.config.mjs",
 		"build": "tsc -noEmit -skipLibCheck && node esbuild.config.mjs production",
+		"lint": "eslint --fix src",
 		"version": "node version-bump.mjs && git add manifest.json versions.json"
 	},
 	"keywords": [],
@@ -13,16 +14,17 @@
 	"license": "MIT",
 	"devDependencies": {
 		"@types/node": "^16.11.6",
-		"@typescript-eslint/eslint-plugin": "5.29.0",
-		"@typescript-eslint/parser": "5.29.0",
+		"@typescript-eslint/eslint-plugin": "8.18.0",
+		"@typescript-eslint/parser": "8.18.0",
 		"builtin-modules": "3.3.0",
-		"esbuild": "0.17.3",
-		"obsidian": "1.7.2",
-		"tslib": "2.4.0",
-		"typescript": "5.7.2",
+		"esbuild": "0.24.0",
 		"esbuild-plugin-wasm-pack": "^1.1.0",
-		"eslint": "8.1.0",
+		"eslint": "9.17.0",
+		"eslint-plugin-unused-imports": "^4.1.4",
+		"obsidian": "1.7.2",
 		"openapi-fetch": "0.13.3",
-		"openapi-typescript": "7.4.4"
+		"openapi-typescript": "7.4.4",
+		"tslib": "2.4.0",
+		"typescript": "5.7.2"
 	}
 }

plugin/src/apply-remote-changes-locally.ts

@@ -1,4 +1,3 @@
-import { Vault } from "obsidian";
 import { Database } from "./database/database";
 import { SyncServer } from "./services/sync_service";
 import { syncRemotelyUpdatedFile } from "./sync-operations/sync-remotely-updated-file";

plugin/src/database/database.ts

@@ -23,7 +23,7 @@ export class Database {
 
 	public constructor(
 		initialState: Partial<StoredDatabase> | undefined,
-		private saveData: (data: any) => Promise<void>
+		private saveData: (data: unknown) => Promise<void>
 	) {
 		initialState = initialState || {};
 		if (

plugin/src/plugin.ts

@@ -1,14 +1,4 @@
-import {
-	App,
-	Editor,
-	MarkdownView,
-	Modal,
-	Notice,
-	Plugin,
-	PluginSettingTab,
-	Setting,
-	WorkspaceLeaf,
-} from "obsidian";
+import { Editor, MarkdownView, Plugin, WorkspaceLeaf } from "obsidian";
 
 import * as lib from "../../backend/sync_lib/pkg/sync_lib.js";
 import * as wasmBin from "../../backend/sync_lib/pkg/sync_lib_bg.wasm";
@@ -29,12 +19,16 @@ export default class SyncPlugin extends Plugin {
 	async onload() {
 		Logger.getInstance().info('Starting plugin "Sample Plugin"');
 
-		await lib.default(Promise.resolve((wasmBin as any).default));
+		await lib.default(
+			Promise.resolve(
+				(wasmBin as any).default // eslint-disable-line @typescript-eslint/no-explicit-any
+			)
+		);
 
 		this.addCommand({
 			id: "sample-editor-command",
 			name: "Sample editor command",
-			editorCallback: (editor: Editor, view: MarkdownView) => {
+			editorCallback: (editor: Editor, _view: MarkdownView) => {
 				console.log(editor.getSelection());
 				editor.replaceSelection("Sample Editor Command");
 			},

plugin/src/services/sync_service.ts

@@ -56,7 +56,7 @@ export class SyncServer {
 		contentBytes: Uint8Array;
 		createdDate: Date;
 	}): Promise<components["schemas"]["DocumentVersion"]> {
-		let response = await this.client.POST("/vaults/{vault_id}/documents", {
+		const response = await this.client.POST("/vaults/{vault_id}/documents", {
 			params: {
 				path: {
 					vault_id: SyncServer.VAULT_ID,
@@ -97,7 +97,7 @@ export class SyncServer {
 		contentBytes: Uint8Array;
 		createdDate: Date;
 	}): Promise<components["schemas"]["DocumentVersion"]> {
-		let response = await this.client.PUT(
+		const response = await this.client.PUT(
 			"/vaults/{vault_id}/documents/{document_id}",
 			{
 				params: {

plugin/src/sync-operations/sync-locally-created-file.ts

@@ -1,10 +1,8 @@
 import * as lib from "../../../backend/sync_lib/pkg/sync_lib.js";
-import { TFile } from "obsidian";
 import { Database } from "src/database/database";
 import { Logger } from "src/logger";
 import { SyncServer } from "src/services/sync_service";
 import { hash } from "src/utils/hash";
-import { isEqualBytes } from "src/utils/is-equal-bytes";
 import { unlockDocument, waitForDocumentLock } from "./locks.js";
 import { FileOperations } from "src/file-operations/file-operations.js";
 import { RelativePath } from "src/database/document-metadata.js";

plugin/src/sync-operations/sync-locally-deleted-file.ts

@@ -2,7 +2,7 @@ import { Database } from "src/database/database";
 import { RelativePath } from "src/database/document-metadata";
 import { Logger } from "src/logger";
 import { SyncServer } from "src/services/sync_service";
-import { tryLockDocument, unlockDocument, waitForDocumentLock } from "./locks";
+import { unlockDocument, waitForDocumentLock } from "./locks";
 
 export async function syncLocallyDeletedFile(
 	database: Database,

plugin/src/sync-operations/sync-locally-updated-file.ts

@@ -1,10 +1,8 @@
 import * as lib from "../../../backend/sync_lib/pkg/sync_lib.js";
-import { TFile } from "obsidian";
 import { Database } from "src/database/database";
 import { Logger } from "src/logger";
 import { SyncServer } from "src/services/sync_service";
 import { hash } from "src/utils/hash";
-import { isEqualBytes } from "src/utils/is-equal-bytes";
 import { unlockDocument, waitForDocumentLock } from "./locks.js";
 import { FileOperations } from "src/file-operations/file-operations.js";
 import { RelativePath } from "src/database/document-metadata.js";

plugin/src/sync-operations/sync-remotely-updated-file.ts

@@ -1,4 +1,3 @@
-import { Vault } from "obsidian";
 import { Database } from "src/database/database";
 import { unlockDocument, waitForDocumentLock } from "./locks";
 import { SyncServer } from "src/services/sync_service";