From 43ad44d59402c3cd5f5ac74edd1f84aed6fcdd12 Mon Sep 17 00:00:00 2001
From: Andras Schmelczer <andras@schmelczer.dev>
Date: Sat, 12 Jul 2025 14:46:01 +0100
Subject: [PATCH] Fix bug & lint

---
 sync-server/src/app_state/cursors.rs                      | 4 +---
 sync-server/src/app_state/database/models.rs              | 4 +---
 sync-server/src/server.rs                                 | 8 ++------
 sync-server/src/server/device_id_header.rs                | 4 +---
 sync-server/src/server/update_document.rs                 | 8 ++++----
 sync-server/src/utils.rs                                  | 2 +-
 .../{is_filetype_mergable.rs => is_file_type_mergable.rs} | 0
 sync-server/src/utils/normalize.rs                        | 4 +---
 8 files changed, 11 insertions(+), 23 deletions(-)
 rename sync-server/src/utils/{is_filetype_mergable.rs => is_file_type_mergable.rs} (100%)

diff --git a/sync-server/src/app_state/cursors.rs b/sync-server/src/app_state/cursors.rs
index 3974f6b6..245109c2 100644
--- a/sync-server/src/app_state/cursors.rs
+++ b/sync-server/src/app_state/cursors.rs
@@ -124,7 +124,5 @@ impl ClientCursorsWithTimeToLive {
         }
     }
 
-    pub fn is_expired(&self, ttl: Duration) -> bool {
-        self.last_updated.elapsed() > ttl
-    }
+    pub fn is_expired(&self, ttl: Duration) -> bool { self.last_updated.elapsed() > ttl }
 }
diff --git a/sync-server/src/app_state/database/models.rs b/sync-server/src/app_state/database/models.rs
index 24c0c370..7796f627 100644
--- a/sync-server/src/app_state/database/models.rs
+++ b/sync-server/src/app_state/database/models.rs
@@ -23,9 +23,7 @@ pub struct StoredDocumentVersion {
 }
 
 impl PartialEq<Self> for StoredDocumentVersion {
-    fn eq(&self, other: &Self) -> bool {
-        self.vault_update_id == other.vault_update_id
-    }
+    fn eq(&self, other: &Self) -> bool { self.vault_update_id == other.vault_update_id }
 }
 
 #[derive(TS, Debug, Clone, Serialize)]
diff --git a/sync-server/src/server.rs b/sync-server/src/server.rs
index cddcc1b5..3f659c97 100644
--- a/sync-server/src/server.rs
+++ b/sync-server/src/server.rs
@@ -179,10 +179,6 @@ async fn shutdown_signal() {
     }
 }
 
-async fn handle_404() -> impl IntoResponse {
-    not_found_error(anyhow!("Page not found"))
-}
+async fn handle_404() -> impl IntoResponse { not_found_error(anyhow!("Page not found")) }
 
-async fn handle_405() -> impl IntoResponse {
-    client_error(anyhow!("Method not allowed"))
-}
+async fn handle_405() -> impl IntoResponse { client_error(anyhow!("Method not allowed")) }
diff --git a/sync-server/src/server/device_id_header.rs b/sync-server/src/server/device_id_header.rs
index b29ec246..be36c8d8 100644
--- a/sync-server/src/server/device_id_header.rs
+++ b/sync-server/src/server/device_id_header.rs
@@ -6,9 +6,7 @@ pub struct DeviceIdHeader(pub String);
 pub static DEVICE_ID_HEADER_NAME: HeaderName = HeaderName::from_static("device-id");
 
 impl Header for DeviceIdHeader {
-    fn name() -> &'static HeaderName {
-        &DEVICE_ID_HEADER_NAME
-    }
+    fn name() -> &'static HeaderName { &DEVICE_ID_HEADER_NAME }
 
     fn decode<'i, I>(values: &mut I) -> Result<Self, headers::Error>
     where
diff --git a/sync-server/src/server/update_document.rs b/sync-server/src/server/update_document.rs
index c228944c..99d3f490 100644
--- a/sync-server/src/server/update_document.rs
+++ b/sync-server/src/server/update_document.rs
@@ -21,7 +21,7 @@ use crate::{
     config::user_config::User,
     errors::{SyncServerError, not_found_error, server_error},
     utils::{
-        dedup_paths::dedup_paths, is_filetype_mergable::is_file_type_mergable,
+        dedup_paths::dedup_paths, is_file_type_mergable::is_file_type_mergable,
         normalize::normalize, sanitize_path::sanitize_path,
     },
 };
@@ -121,9 +121,9 @@ pub async fn update_document(
     }
 
     let merged_content = if is_file_type_mergable(&sanitized_relative_path)
-        && is_binary(&parent_document.content)
-        && is_binary(&latest_version.content)
-        && is_binary(&content)
+        && !is_binary(&parent_document.content)
+        && !is_binary(&latest_version.content)
+        && !is_binary(&content)
     {
         reconcile(
             str::from_utf8(&parent_document.content)
diff --git a/sync-server/src/utils.rs b/sync-server/src/utils.rs
index 63876468..010524de 100644
--- a/sync-server/src/utils.rs
+++ b/sync-server/src/utils.rs
@@ -1,4 +1,4 @@
 pub mod dedup_paths;
-pub mod is_filetype_mergable;
+pub mod is_file_type_mergable;
 pub mod normalize;
 pub mod sanitize_path;
diff --git a/sync-server/src/utils/is_filetype_mergable.rs b/sync-server/src/utils/is_file_type_mergable.rs
similarity index 100%
rename from sync-server/src/utils/is_filetype_mergable.rs
rename to sync-server/src/utils/is_file_type_mergable.rs
diff --git a/sync-server/src/utils/normalize.rs b/sync-server/src/utils/normalize.rs
index 6553dd25..adb83ac1 100644
--- a/sync-server/src/utils/normalize.rs
+++ b/sync-server/src/utils/normalize.rs
@@ -8,6 +8,4 @@ where
     Ok(normalize_string(&s))
 }
 
-pub fn normalize_string(s: &str) -> String {
-    s.trim().to_lowercase()
-}
+pub fn normalize_string(s: &str) -> String { s.trim().to_lowercase() }