Use efficient filters

frontend/sync-client/src/utils/globs-to-regexes.ts

@@ -2,17 +2,20 @@ import { makeRe } from "minimatch";
 import type { Logger } from "../tracing/logger";
 
 export function globsToRegexes(globs: string[], logger: Logger): RegExp[] {
-	return globs
-		.map((pattern) => {
-			const result = makeRe(pattern, {
-				dot: true
-			});
-			if (result === false) {
-				logger.warn(
-					`Failed to parse ${pattern}' as a glob pattern, skipping it`
-				);
-			}
-			return result;
-		})
-		.filter((pattern) => pattern !== false);
+	return (
+		globs
+			.map((pattern) => {
+				const result = makeRe(pattern, {
+					dot: true
+				});
+				if (result === false) {
+					logger.warn(
+						`Failed to parse ${pattern}' as a glob pattern, skipping it`
+					);
+				}
+				return result;
+			})
+			// eslint-disable-next-line no-restricted-syntax -- Filtering out false values, not removing a specific item
+			.filter((pattern) => pattern !== false)
+	);
 }

frontend/sync-client/src/utils/remove-from-array.ts

@@ -0,0 +1,17 @@
+/**
+ * Efficiently removes a specific item from an array by modifying it in place.
+ * This is more efficient than using `.filter(item => item !== toRemove)` as it avoids creating a new array
+ *
+ * @param array The array to modify
+ * @param item The item to remove
+ * @returns true if the item was found and removed, false otherwise
+ */
+export function removeFromArray<T>(array: T[], item: T): boolean {
+    const index = array.indexOf(item);
+    if (index !== -1) {
+        // eslint-disable-next-line no-restricted-syntax -- This is the implementation of the helper itself
+        array.splice(index, 1);
+        return true;
+    }
+    return false;
+}