No rate limiting saves

frontend/obsidian-plugin/src/views/settings/settings-tab.ts

@@ -468,39 +468,7 @@ export class SyncSettingsTab extends PluginSettingTab {
                     })
             );
 
-        new Setting(containerEl)
-            .setName("Minimum save interval (ms)")
-            .setDesc(
-                "The minimum time between saving settings and database to disk, in milliseconds. Lower values save more frequently but may impact performance."
-            )
-            .addText((input) =>
-                input
-                    .setValue(
-                        this.syncClient
-                            .getSettings()
-                            .minimumSaveIntervalMs.toString()
-                    )
-                    .onChange(async (value) => {
-                        if (value === "") {
-                            return;
-                        }
-                        let parsedValue = Number.parseInt(value, 10);
-                        if (Number.isNaN(parsedValue) || parsedValue < 0) {
-                            parsedValue =
-                                this.syncClient.getSettings()
-                                    .minimumSaveIntervalMs;
-                        }
 
-                        if (value !== parsedValue.toString()) {
-                            input.setValue(parsedValue.toString());
-                        }
-
-                        return this.syncClient.setSetting(
-                            "minimumSaveIntervalMs",
-                            parsedValue
-                        );
-                    })
-            );
     }
 
     private setStatusDescriptionSubscription(
@@ -536,8 +504,7 @@ export class SyncSettingsTab extends PluginSettingTab {
         const updateTitle = (
             currentValue: SyncSettings[keyof SyncSettings]
         ): void => {
-            title.innerText = `${name}${
+            title.innerText = `${name}${currentValue !== this.syncClient.getSettings()[settingName]
-                currentValue !== this.syncClient.getSettings()[settingName]
                     ? " (unsaved)"
                     : ""
                 }`;

frontend/sync-client/src/persistence/settings.ts

@@ -14,7 +14,6 @@ export interface SyncSettings {
     diffCacheSizeMB: number;
     enableTelemetry: boolean;
     networkRetryIntervalMs: number;
-    minimumSaveIntervalMs: number;
 }
 
 export const DEFAULT_SETTINGS: SyncSettings = {
@@ -29,7 +28,6 @@ export const DEFAULT_SETTINGS: SyncSettings = {
     diffCacheSizeMB: 4,
     enableTelemetry: false,
     networkRetryIntervalMs: 1000,
-    minimumSaveIntervalMs: 1000
 };
 
 export class Settings {

frontend/sync-client/src/sync-client.ts

@@ -150,10 +150,6 @@ export class SyncClient {
             }
         );
 
-        const rateLimitedSave = rateLimit(
-            persistence.save,
-            () => settings.getSettings().minimumSaveIntervalMs
-        );
 
         const syncEventQueue = new SyncEventQueue(
             settings,
@@ -161,7 +157,7 @@ export class SyncClient {
             state.database,
             async (data): Promise<void> => {
                 state = { ...state, database: data };
-                await rateLimitedSave(state);
+                await persistence.save(state);
             }
         );