Fable clean up

scripts/check-overflow.mjs

@@ -1,200 +1,32 @@
-import { createServer } from 'node:http';
-import { mkdir, readdir, readFile, rm, stat } from 'node:fs/promises';
 import path from 'node:path';
-import { chromium } from 'playwright';
+import {
+  CONTEXT_TIMEOUT_MS,
+  PAGE_TIMEOUT_MS,
+  cleanupBrowserTmp,
+  openBrowser,
+  safeCloseBrowser,
+  safeCloseContext,
+  safeClosePage,
+  setupBrowserTmp,
+  shouldRetryNavigation,
+  withTimeout,
+} from './lib/browser.mjs';
+import { discoverRoutes, requireDist, startDistServer } from './lib/dist.mjs';
 
-const dist = path.resolve('dist');
 const browserTmp = path.resolve('.astro', 'playwright-overflow-tmp');
-const INDEX_FILE = 'index.html';
 const MAX_NAV_RETRIES = 4;
 // Common device widths: iPhone SE / Galaxy S / iPhone 14 / iPad portrait /
 // iPad landscape / common laptop / full HD desktop.
 const VIEWPORT_WIDTHS = [320, 390, 430, 768, 1024, 1440, 1920];
-const CLOSE_TIMEOUT_MS = 3000;
-const LAUNCH_TIMEOUT_MS = 10000;
-const CONTEXT_TIMEOUT_MS = 8000;
-const PAGE_TIMEOUT_MS = 15000;
 const MEASURE_TIMEOUT_MS = 25000;
 
-const MIME = {
-  '.html': 'text/html; charset=utf-8',
-  '.css': 'text/css; charset=utf-8',
-  '.js': 'text/javascript; charset=utf-8',
-  '.svg': 'image/svg+xml',
-  '.png': 'image/png',
-  '.jpg': 'image/jpeg',
-  '.jpeg': 'image/jpeg',
-  '.webp': 'image/webp',
-  '.avif': 'image/avif',
-  '.ico': 'image/x-icon',
-  '.woff': 'font/woff',
-  '.woff2': 'font/woff2',
-  '.mp4': 'video/mp4',
-  '.webm': 'video/webm',
-  '.vtt': 'text/vtt; charset=utf-8',
-  '.pdf': 'application/pdf',
-};
-
-function contentType(file) {
-  const ext = path.extname(file).toLowerCase();
-  return MIME[ext] ?? 'application/octet-stream';
-}
-
-async function walk(dir) {
-  const entries = await readdir(dir, { withFileTypes: true });
-  const files = [];
-  for (const entry of entries) {
-    const fullPath = path.join(dir, entry.name);
-    if (entry.isDirectory()) {
-      files.push(...(await walk(fullPath)));
-    } else {
-      files.push(fullPath);
-    }
-  }
-  return files;
-}
-
-async function discoverRoutes() {
-  const files = await walk(dist);
-  const routes = new Set();
-  for (const file of files) {
-    if (!file.endsWith('.html')) continue;
-    const rel = path.relative(dist, file).replaceAll(path.sep, '/');
-    if (rel === '404.html') continue;
-    if (rel === INDEX_FILE) {
-      routes.add('/');
-    } else if (rel.endsWith(`/${INDEX_FILE}`)) {
-      routes.add('/' + rel.slice(0, -INDEX_FILE.length));
-    } else {
-      routes.add('/' + rel.replace(/\.html$/, '/'));
-    }
-  }
-  return [...routes].sort();
-}
-
-async function resolveFile(url) {
-  const parsed = new URL(url, 'http://localhost');
-  const safePath = path
-    .normalize(decodeURIComponent(parsed.pathname))
-    .replace(/^\/+/, '')
-    .replace(/^(\.\.(\/|\\|$))+/, '');
-  const candidate = path.join(dist, safePath);
-  const candidates = [
-    candidate,
-    path.join(candidate, 'index.html'),
-    path.join(dist, `${safePath}.html`),
-  ];
-
-  for (const file of candidates) {
-    try {
-      const fileStat = await stat(file);
-      if (fileStat.isFile()) return file;
-    } catch {
-      // Try the next candidate.
-    }
-  }
-
-  return path.join(dist, '404.html');
-}
-
-try {
-  await stat(dist);
-} catch {
-  throw new Error('dist/ does not exist. Run npm run build first.');
-}
-
-// Some CI/dev containers mount /tmp as a very small tmpfs. Chromium uses the
-// process temp directory for profiles and internal files; putting it under the
-// already-ignored .astro/ directory keeps the overflow check reproducible even
-// when the system temp mount is full.
-await rm(browserTmp, { recursive: true, force: true });
-await mkdir(browserTmp, { recursive: true });
-process.env.TMPDIR = browserTmp;
-process.env.TMP = browserTmp;
-process.env.TEMP = browserTmp;
+await requireDist();
+await setupBrowserTmp(browserTmp);
 
 const routes = await discoverRoutes();
-
-const server = createServer(async (req, res) => {
-  try {
-    const file = await resolveFile(req.url ?? '/');
-    const body = await readFile(file);
-    res.writeHead(200, { 'content-type': contentType(file) });
-    res.end(body);
-  } catch (error) {
-    res.writeHead(500, { 'content-type': 'text/plain; charset=utf-8' });
-    res.end(String(error));
-  }
-});
-
-await new Promise((resolve) => server.listen(0, '127.0.0.1', resolve));
-const { port } = server.address();
+const { server, port } = await startDistServer();
 const failures = [];
 
-function launchBrowser() {
-  return chromium.launch({
-    headless: true,
-    env: {
-      ...process.env,
-      TMPDIR: browserTmp,
-      TMP: browserTmp,
-      TEMP: browserTmp,
-    },
-    args: ['--disable-dev-shm-usage', '--disable-gpu', '--no-sandbox'],
-  });
-}
-
-async function withTimeout(promise, timeoutMs, label) {
-  let timeout;
-  try {
-    return await Promise.race([
-      promise,
-      new Promise((_, reject) => {
-        timeout = setTimeout(() => reject(new Error(label)), timeoutMs);
-      }),
-    ]);
-  } finally {
-    clearTimeout(timeout);
-  }
-}
-
-async function safeClosePage(page) {
-  await withTimeout(
-    page.close(),
-    CLOSE_TIMEOUT_MS,
-    'Timed out while closing Playwright page'
-  ).catch(() => {});
-}
-
-async function safeCloseContext(context) {
-  await withTimeout(
-    context.close(),
-    CLOSE_TIMEOUT_MS,
-    'Timed out while closing Playwright context'
-  ).catch(() => {});
-}
-
-async function safeCloseBrowser(browser) {
-  const childProcess = browser.process?.();
-  try {
-    await withTimeout(
-      browser.close(),
-      CLOSE_TIMEOUT_MS,
-      'Timed out while closing Chromium'
-    );
-  } catch {
-    childProcess?.kill('SIGKILL');
-  }
-}
-
-async function openBrowser() {
-  return withTimeout(
-    launchBrowser(),
-    LAUNCH_TIMEOUT_MS,
-    'Timed out while launching Chromium'
-  );
-}
-
 async function newMeasurementContext(browser, width) {
   const context = await browser.newContext({
     viewport: { width, height: 900 },
@@ -227,13 +59,6 @@ async function measureViewport(page) {
   }));
 }
 
-function shouldRetryNavigation(error) {
-  const message = error instanceof Error ? error.message : String(error);
-  return /ERR_INSUFFICIENT_RESOURCES|Execution context was destroyed|Target.*closed|has been closed|Timed out while|navigation/i.test(
-    message
-  );
-}
-
 async function measureRoute(context, route) {
   let page;
   try {
@@ -263,7 +88,7 @@ try {
     let browser;
     let context;
     try {
-      browser = await openBrowser();
+      browser = await openBrowser(browserTmp);
       context = await openMeasurementContext(browser, width);
       for (const route of routes) {
         let result;
@@ -278,7 +103,7 @@ try {
             }
             await safeCloseContext(context);
             await safeCloseBrowser(browser);
-            browser = await openBrowser();
+            browser = await openBrowser(browserTmp);
             context = await openMeasurementContext(browser, width);
           }
         }
@@ -296,7 +121,7 @@ try {
   }
 } finally {
   server.close();
-  await rm(browserTmp, { recursive: true, force: true }).catch(() => {});
+  await cleanupBrowserTmp(browserTmp);
 }
 
 if (failures.length > 0) {