Lint

src/types/number_or_string.rs

@@ -1,5 +1,4 @@
-use std::borrow::Cow;
+use std::{borrow::Cow, fmt::Debug};
-use std::fmt::Debug;
 
 #[cfg(feature = "serde")]
 use serde::{Deserialize, Serialize};
@@ -59,27 +58,19 @@ impl From<NumberOrString> for JsValue {
 }
 
 impl From<i64> for NumberOrString {
-    fn from(value: i64) -> Self {
+    fn from(value: i64) -> Self { NumberOrString::Number(value) }
-        NumberOrString::Number(value)
-    }
 }
 
 impl From<String> for NumberOrString {
-    fn from(value: String) -> Self {
+    fn from(value: String) -> Self { NumberOrString::Text(value) }
-        NumberOrString::Text(value)
-    }
 }
 
 impl From<&str> for NumberOrString {
-    fn from(value: &str) -> Self {
+    fn from(value: &str) -> Self { NumberOrString::Text(value.to_owned()) }
-        NumberOrString::Text(value.to_string())
-    }
 }
 
 impl<'a> From<Cow<'a, str>> for NumberOrString {
-    fn from(value: Cow<'a, str>) -> Self {
+    fn from(value: Cow<'a, str>) -> Self { NumberOrString::Text(value.into_owned()) }
-        NumberOrString::Text(value.into_owned())
-    }
 }
 
 /// Error type for deserialisation failures
@@ -110,7 +101,5 @@ impl std::error::Error for DeserialisationError {}
 
 #[cfg(feature = "wasm")]
 impl From<DeserialisationError> for JsValue {
-    fn from(error: DeserialisationError) -> Self {
+    fn from(error: DeserialisationError) -> Self { JsValue::from_str(&error.message) }
-        JsValue::from_str(&error.message)
-    }
 }