diff --git a/frontend/obsidian-plugin/src/views/history-view.ts b/frontend/obsidian-plugin/src/views/history-view.ts index 457836d..56c8d53 100644 --- a/frontend/obsidian-plugin/src/views/history-view.ts +++ b/frontend/obsidian-plugin/src/views/history-view.ts @@ -94,15 +94,7 @@ export class HistoryView extends ItemView { container.empty(); container.createEl("h4", { text: "VaultLink History" }); - const entries = this.client.history - .getEntries() - .reverse() - .filter( - (entry) => - entry.status !== SyncStatus.NO_OP || - this.client.settings.getSettings().displayNoopSyncEvents - ); - + const entries = this.client.history.getEntries().reverse(); entries.forEach((entry) => { container.createDiv( { diff --git a/frontend/obsidian-plugin/src/views/settings-tab.ts b/frontend/obsidian-plugin/src/views/settings-tab.ts index 5cd5942..b3a39dd 100644 --- a/frontend/obsidian-plugin/src/views/settings-tab.ts +++ b/frontend/obsidian-plugin/src/views/settings-tab.ts @@ -291,25 +291,6 @@ export class SyncSettingsTab extends PluginSettingTab { private renderViewSettings(containerEl: HTMLElement): void { containerEl.createEl("h3", { text: "View" }); - new Setting(containerEl) - .setName("Show no-op sync operations in history") - .setDesc( - "Enabling this will make the history view more verbose while also providing more explanation for the scyning choices made." - ) - .addToggle((toggle) => - toggle - .setValue( - this.syncClient.settings.getSettings() - .displayNoopSyncEvents - ) - .onChange(async (value) => - this.syncClient.settings.setSetting( - "displayNoopSyncEvents", - value - ) - ) - ); - new Setting(containerEl) .setName("Minimum log level") .setDesc( diff --git a/frontend/sync-client/src/persistence/settings.ts b/frontend/sync-client/src/persistence/settings.ts index 75433b3..29a77ff 100644 --- a/frontend/sync-client/src/persistence/settings.ts +++ b/frontend/sync-client/src/persistence/settings.ts @@ -8,7 +8,6 @@ export interface SyncSettings { fetchChangesUpdateIntervalMs: number; syncConcurrency: number; isSyncEnabled: boolean; - displayNoopSyncEvents: boolean; minimumLogLevel: LogLevel; maxFileSizeMB: number; } @@ -20,7 +19,6 @@ const DEFAULT_SETTINGS: SyncSettings = { fetchChangesUpdateIntervalMs: 1000, syncConcurrency: 1, isSyncEnabled: false, - displayNoopSyncEvents: false, minimumLogLevel: LogLevel.INFO, maxFileSizeMB: 10 }; diff --git a/frontend/sync-client/src/tracing/sync-history.ts b/frontend/sync-client/src/tracing/sync-history.ts index a6523b5..ea87bca 100644 --- a/frontend/sync-client/src/tracing/sync-history.ts +++ b/frontend/sync-client/src/tracing/sync-history.ts @@ -21,7 +21,6 @@ export enum SyncSource { } export enum SyncStatus { - NO_OP = "NO_OP", SUCCESS = "SUCCESS", ERROR = "ERROR" } @@ -83,15 +82,11 @@ export class SyncHistory { this.logger.info( `History entry: ${entry.relativePath} - ${entry.message}` ); - } else if (entry.status === SyncStatus.ERROR) { + } else { this.status.error++; this.logger.error( `Error syncing file: ${entry.relativePath} - ${entry.message}` ); - } else { - this.logger.debug( - `No-op syncing file: ${entry.relativePath} - ${entry.message}` - ); } this.syncHistoryUpdateListeners.forEach((listener) => {