From 65ec6d6f9b1c2e1bbc16ef292bc855dfdb770da7 Mon Sep 17 00:00:00 2001 From: Andras Schmelczer Date: Fri, 8 Jul 2022 12:35:35 +0200 Subject: [PATCH] Do no supress exception --- great_ai/large_file/large_file/large_file_base.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/great_ai/large_file/large_file/large_file_base.py b/great_ai/large_file/large_file/large_file_base.py index 5bee7db..4f412e1 100644 --- a/great_ai/large_file/large_file/large_file_base.py +++ b/great_ai/large_file/large_file/large_file_base.py @@ -5,7 +5,7 @@ from abc import ABC, abstractmethod from functools import lru_cache from pathlib import Path from types import TracebackType -from typing import IO, Any, List, Optional, Type, Union, cast +from typing import IO, Any, List, Literal, Optional, Type, Union, cast from great_ai.utilities import ConfigFile, get_logger @@ -123,7 +123,7 @@ class LargeFileBase(ABC): type: Optional[Type[BaseException]], exc: Optional[BaseException], traceback: Optional[TracebackType], - ) -> bool: + ) -> Literal[False]: self._file.close() if type is None: @@ -133,7 +133,7 @@ class LargeFileBase(ABC): else: logger.exception("Could not finish operation.") - return True + return False @property def _local_name(self) -> str: